From 0caaad8436761475f09abd24c75556f394362307 Mon Sep 17 00:00:00 2001
From: Roy Qu <royqh1979@gmail.com>
Date: Sat, 31 Dec 2022 09:36:50 +0800
Subject: [PATCH] - fix: Action "Run all problem cases" is triggered twice by
 one clicked.

---
 NEWS.md                    |  2 +-
 RedPandaIDE/mainwindow.cpp | 13 ++++++-------
 RedPandaIDE/mainwindow.h   |  2 +-
 3 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/NEWS.md b/NEWS.md
index e5e622a5..048c52ed 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -6,7 +6,7 @@ Red Panda C++ Version 2.8
   - enhancement: "Run" / "Generate Assembly" for project source files
   - fix: Can't set project icon to "app.ico" in the project folder, if the project doesn't has icon.
   - fix: Resource compilation items is missing in the auto generated makefile, if the project's icon is removed and re-added.
-
+  - fix: Action "Run all problem cases" is triggered twice by one clicked.
 
 Red Panda C++ Version 2.7
 
diff --git a/RedPandaIDE/mainwindow.cpp b/RedPandaIDE/mainwindow.cpp
index ac4e54d9..501bbe8d 100644
--- a/RedPandaIDE/mainwindow.cpp
+++ b/RedPandaIDE/mainwindow.cpp
@@ -664,7 +664,7 @@ void MainWindow::updateCompileActions(const Editor *e)
         ui->actionRebuild->setEnabled(false);
         ui->actionGenerate_Assembly->setEnabled(false);
         ui->actionDebug->setEnabled(false);
-        ui->btnRunAllProblemCases->setEnabled(false);
+        mProblem_RunAllCases->setEnabled(false);
     } else {
         bool forProject=false;
         bool canRun = false;
@@ -703,7 +703,7 @@ void MainWindow::updateCompileActions(const Editor *e)
         ui->actionRebuild->setEnabled(canCompile);
         ui->actionGenerate_Assembly->setEnabled(canGenerateAssembly);
         ui->actionDebug->setEnabled(canRun);
-        ui->btnRunAllProblemCases->setEnabled(canRun);
+        mProblem_RunAllCases->setEnabled(canRun && mOJProblemModel.count()>0);
     }
     if (!mDebugger->executing()) {
         disableDebugActions();
@@ -2535,7 +2535,7 @@ void MainWindow::createCustomActions()
                 tr("Run All Cases"),
                 "Problem_RunAllCases");
     connect(mProblem_RunAllCases, &QAction::triggered, this,
-            &MainWindow::on_btnRunAllProblemCases_clicked);
+            &MainWindow::onProblemRunAllCases);
 
     mProblem_RunCurrentCase = createShortcutCustomableAction(
                 tr("Run Current Case"),
@@ -3892,12 +3892,11 @@ void MainWindow::onProblemCaseIndexChanged(const QModelIndex &current, const QMo
         POJProblemCase problemCase = mOJProblemModel.getCase(idx.row());
         if (problemCase) {
             mProblem_RemoveCases->setEnabled(true);
-            ui->btnRunAllProblemCases->setEnabled(ui->actionRun->isEnabled());
+            mProblem_RunAllCases->setEnabled(ui->actionRun->isEnabled());
             fillProblemCaseInputAndExpected(problemCase);
             ui->txtProblemCaseOutput->clear();
             ui->txtProblemCaseOutput->setPlainText(problemCase->output);
             updateProblemCaseOutput(problemCase);
-
             return;
         }
     }
@@ -3912,7 +3911,7 @@ void MainWindow::onProblemCaseIndexChanged(const QModelIndex &current, const QMo
     ui->txtProblemCaseExpectedOutputFileName->setToolTip("");
 
     mProblem_RemoveCases->setEnabled(false);
-    ui->btnRunAllProblemCases->setEnabled(false);
+    mProblem_RunAllCases->setEnabled(false);
     ui->txtProblemCaseInputFileName->clear();
     ui->btnProblemCaseInputFileName->setEnabled(false);
     ui->txtProblemCaseInput->clear();
@@ -8096,7 +8095,7 @@ void MainWindow::onAddProblemCase()
     ui->tblProblemCases->setCurrentIndex(mOJProblemModel.index(mOJProblemModel.count()-1,0));
 }
 
-void MainWindow::on_btnRunAllProblemCases_clicked()
+void MainWindow::onProblemRunAllCases()
 {    
     if (mOJProblemModel.count()<=0)
         return;
diff --git a/RedPandaIDE/mainwindow.h b/RedPandaIDE/mainwindow.h
index 04f3ae6f..c6c3a6cd 100644
--- a/RedPandaIDE/mainwindow.h
+++ b/RedPandaIDE/mainwindow.h
@@ -623,7 +623,7 @@ private slots:
 
     void onAddProblemCase();
 
-    void on_btnRunAllProblemCases_clicked();
+    void onProblemRunAllCases();
 
     void on_actionC_Reference_triggered();