- fix: Can't correctly set project file's encoding back to 'UTF-8'/'ANSI' in the project options dialog/files setting page.

NEWS.md

@@ -16,6 +16,7 @@ Red Panda C++ Version 2.10
   - fix: Settings in Options/Tools/General is messed up when switching items in the list.
   - fix: Infos in the status bar not correctly updated when editor closed.
   - change: Project's encoding shouldn't be set to "auto detect"
+  - fix: Can't correctly set project file's encoding back to 'UTF-8'/'ANSI' in the project options dialog/files setting page.
 
 Red Panda C++ Version 2.9
 

RedPandaIDE/editor.cpp

@@ -529,9 +529,12 @@ const QByteArray& Editor::encodingOption() const noexcept{
     return mEncodingOption;
 }
 void Editor::setEncodingOption(const QByteArray& encoding) noexcept{
-    if (mEncodingOption == encoding)
+    QByteArray newEncoding=encoding;
+    if (mProject && encoding==ENCODING_PROJECT)
+        newEncoding=mProject->options().encoding;
+    if (mEncodingOption == newEncoding)
         return;
-    mEncodingOption = encoding;
+    mEncodingOption = newEncoding;
     if (!isNew()) {
         try {
             loadFile();

RedPandaIDE/settingsdialog/projectfileswidget.cpp

@@ -270,6 +270,8 @@ void ProjectFilesWidget::on_cbEncodingDetail_currentTextChanged(const QString &)
     PProjectUnit unit = currentUnit();
     if(!unit)
         return;
+    if (ui->cbEncodingDetail->currentText().isEmpty())
+        return;
     unit->setEncoding(ui->cbEncodingDetail->currentText().toUtf8());
 }