- fix: selection is not correctly set after input in column mode

NEWS.md

@@ -1,6 +1,7 @@
 Red Panda C++ Version 1.1.6
 
   - fix: block indent doesn't work
+  - fix: selection is not correctly set after input in column mode 
 
 Red Panda C++ Version 1.1.5
 

RedPandaIDE/qsynedit/SynEdit.cpp

@@ -2541,25 +2541,20 @@ void SynEdit::doTabKey()
         doBlockIndent();
         return;
     }
-    int i = 0;
+    mUndoList->beginBlock();
-    {
+    if (selAvail()) {
-        mUndoList->beginBlock();
+        setSelectedTextEmpty();
-        auto action = finally([this]{
-            mUndoList->endBlock();
-        });
-        if (selAvail()) {
-            setSelectedTextEmpty();
-        }
-        QString Spaces;
-        if (mOptions.testFlag(eoTabsToSpaces)) {
-            int cols = charToColumn(mCaretY,mCaretX);
-            i = tabWidth() - (cols) % tabWidth();
-            Spaces = QString(i,' ');
-        } else {
-            Spaces = '\t';
-        }
-        setSelTextPrimitive(QStringList(Spaces));
     }
+    QString Spaces;
+    if (mOptions.testFlag(eoTabsToSpaces)) {
+        int cols = charToColumn(mCaretY,mCaretX);
+        int i = tabWidth() - (cols) % tabWidth();
+        Spaces = QString(i,' ');
+    } else {
+        Spaces = '\t';
+    }
+    setSelTextPrimitive(QStringList(Spaces));
+    mUndoList->endBlock();
     ensureCursorPosVisible();
 }
 
@@ -6634,10 +6629,9 @@ void SynEdit::onLinesChanged()
     if (mActiveSelectionMode == SynSelectionMode::Column) {
         BufferCoord oldBlockStart = blockBegin();
         BufferCoord oldBlockEnd = blockEnd();
-        oldBlockStart.ch = mCaretX;
+        int colEnd = charToColumn(mCaretY,mCaretX);
-        int colEnd = charToColumn(oldBlockStart.line,oldBlockStart.ch);
+        oldBlockStart.ch = columnToChar(oldBlockStart.line,colEnd);
-        int charEnd = columnToChar(oldBlockEnd.line,colEnd);
+        oldBlockEnd.ch = columnToChar(oldBlockEnd.line,colEnd);
-        oldBlockEnd.ch =  charEnd;
         setBlockBegin(oldBlockStart);
         setBlockEnd(oldBlockEnd);
     } else {